fix: allow localhost in chat.agent.allowedNetworkDomains#317732
Open
thonhaus wants to merge 2 commits into
Open
fix: allow localhost in chat.agent.allowedNetworkDomains#317732thonhaus wants to merge 2 commits into
thonhaus wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue in the agent network domain filtering logic where localhost (and other non–well-known-suffix hosts such as loopback IPs) could not be matched by chat.agent.allowedNetworkDomains when specified as a bare pattern, causing requests to be blocked even when explicitly allowlisted.
Changes:
- Adjusted domain-pattern normalization so allow/deny patterns are not subject to the “well-known TLD / file-extension” heuristic filtering.
- Added unit tests to ensure
localhostpatterns match correctly and thatlocalhostcan be allowed/denied via configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/platform/networkFilter/common/domainMatcher.ts |
Ensures allow/deny patterns are normalized in a way that supports localhost and similar explicit patterns. |
src/vs/platform/networkFilter/test/common/domainMatcher.test.ts |
Adds coverage for localhost matching and allow/deny behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #314339